Tân Î-sîn
ea58bac548
Replace link has button role with button tag
...
# Change HTML tag to button
Replace the link tag with an HTML button to prevent some screen readers from having confusing announcements. By using the HTML button, users can use the Enter and Space keys to activate actions by default, instead of implementing them in JavaScript.
# Differentiate links and buttons visually
When activating the link element, the user may expect the web page to navigate to the URL and the page will refresh; when activating the button element, the user may expect the web page to still be on the same page, so that their current state, such as: input value, won't disappear.
Links and buttons should have different styles visually, so that users can't expect what will happen when they activate a link or a button.
I added the underline to the links, because that is the common pattern. Buttons have border and background color in a common pattern. But I think that will change the current layout drastically. So I added the focus, hover and active classes to the buttons instead.
2024-02-09 17:09:30 -08:00
krvpb024
0f85c0511a
remove item focus outline overlapped on current style
2024-02-09 16:54:29 -08:00
krvpb024
27749a2877
change focus target on items when using keyboard navigation
2024-02-09 16:54:29 -08:00
krvpb024
facf17db3f
remove icon img alt text
2024-02-07 21:59:09 -08:00
krvpb024
6eac968083
add keyboard shortcut and aria attribute to menu button
2024-02-07 21:56:24 -08:00
Frédéric Guillot
5ce5c47499
Remove translation key page.categories.unread_counter
2024-02-05 21:39:02 -08:00
Frédéric Guillot
9336891e67
Restore menu toggle when clicking on the logo
...
The caret icon is too small on smartphone to expand/collapse the menu
2024-02-05 21:18:06 -08:00
krvpb024
39368ece9a
add alert role to alert message element
2024-02-05 20:14:23 -08:00
krvpb024
4f57309380
remove button role on element which perform navigation
2024-02-05 20:10:38 -08:00
krvpb024
57e7bd5bc9
add button role to links with action
2024-02-05 20:10:38 -08:00
krvpb024
bf54222be7
hide menu button in desktop layout instead of icon
2024-02-04 21:36:31 -08:00
Frédéric Guillot
7d9f174b3f
Add missing label ID for custom CSS field
2024-02-04 13:41:23 -08:00
Frédéric Guillot
bf4d31eebe
Add styling to search button
2024-02-04 13:36:31 -08:00
Frédéric Guillot
f203326a29
Improve translation of hidden aria elements
2024-02-04 13:12:54 -08:00
krvpb024
8367413e84
change links that could perform actions to buttons
2024-02-04 10:47:30 -08:00
krvpb024
9b6dbd422c
change article html structure for accessibility
2024-02-04 10:47:30 -08:00
krvpb024
531e80f580
fix entry page layout has changed
2024-02-04 10:47:30 -08:00
krvpb024
890a34e1bd
remove code for debug and comment
2024-02-04 10:47:30 -08:00
krvpb024
7413e383a8
fix search and star function
2024-02-04 10:47:30 -08:00
krvpb024
7496479380
change header tag usage to match landmark meaning
2024-02-04 10:47:30 -08:00
krvpb024
6c78a1d635
improve feed, entry, category a11y
2024-02-04 10:47:30 -08:00
krvpb024
6413c9f9f7
add nav landmark to settings and feed menu
2024-02-04 10:47:30 -08:00
krvpb024
352aeb0490
fix missing translation key
2024-02-04 10:47:30 -08:00
krvpb024
61f52d971a
fix h1 font-size
2024-02-04 10:47:30 -08:00
krvpb024
fa7508e28d
change search summary icon
2024-02-04 10:47:30 -08:00
krvpb024
c217a31444
fix search label and login view not define header
2024-02-04 10:47:30 -08:00
krvpb024
84576f2c29
fix menu responsive layout
2024-02-04 10:47:30 -08:00
krvpb024
da11416b39
change layout structure by moving header
2024-02-04 10:47:30 -08:00
krvpb024
6a9a590c7f
add search landmark and disclosure pattern to menu
2024-02-04 10:47:30 -08:00
krvpb024
f23e6a3352
add skip to content link
2024-02-04 10:47:30 -08:00
krvpb024
b568b1d41d
improve page-header a11y
...
add nav landmark for links
labeling the purpose of nav in page-header
labeling the meaning of total number in page-header title
2024-02-04 10:47:30 -08:00
Matt Stobo
4a50ca9122
Allow filtering feeds on entry.Author
2024-01-31 19:42:07 -08:00
MDeLuise
1e704468a5
feat: add linkace service integration
2024-01-25 18:04:14 -08:00
Frédéric Guillot
e8147f26b9
Fix incorrect label for
attribute
2024-01-24 20:37:12 -08:00
Andrew Gunnerson
6648e0af38
Revert "touch_handler: Fix scroll up behavior on Firefox Android"
...
This reverts commit 344a237af8
.
The previous behavior is more correct due to the use of preventDefault()
and the commit was introduced only as a workaround. As of [1], the
underlying issue in Firefox has been fixed and downward swipes to scroll
up are no longer ignored every other attempt.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1847305
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1853075
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1724755
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
2024-01-23 19:33:08 -08:00
Dave
1159dd6982
Add addDynamicIframe
rewrite function.
...
Add unit tests for `add_dynamic_iframe` rewrite.
2024-01-23 19:23:57 -08:00
Frédéric Guillot
50341759b6
Fix typo in log message
2024-01-22 20:15:38 -08:00
dzaikos
d68f2306c6
Add attribute to add_dynamic_image rewrite candidates.
2024-01-21 14:27:06 -08:00
Christoffer Strömblad
578743de1f
Add item-meta-info-reading-time
CSS class
2024-01-20 10:53:02 -08:00
Frédéric Guillot
8553188ae4
Add missing translation argument
2024-01-20 10:48:27 -08:00
Frédéric Guillot
87c9ef6b48
Rewrite relative RSS Bridge URL
2024-01-13 14:54:36 -08:00
Frédéric Guillot
ce32d181d5
Change default Accept header
2024-01-13 13:53:57 -08:00
Frédéric Guillot
e2d33f680e
Fix incorrect condition
2024-01-11 19:04:50 -08:00
Ryan Stafford
980c5c63df
Limit feed/category entry pagination to unread entries when coming from unread entry list
2024-01-09 21:44:25 -08:00
Filipe de Luna
1441dc7600
Update entry processor to allow blocking/keeping entries by tags
2024-01-09 21:15:11 -08:00
notsmarthuman
4590da2fc3
Add FORCE_REFRESH_INTERVAL
config option
2024-01-02 18:33:15 -08:00
Stephan Brauer
eb9ac861ea
Update German translation.
...
- Translate missing entries.
- Hiphenate some phrases.
- Improve some translation.
- Some translations where seemingly done automatically.
- Some translation could be phrased a bit better (subjectively).
2023-12-31 10:01:48 -08:00
Jan Tojnar
074393d3bf
fix: Include type for OPML subscriptions
...
As per [OPML 2.0 specification]:
> Each sub-element of the body of the OPML document is a node of type rss or an outline element that contains nodes of type rss.
> Required attributes: type, text, xmlUrl.
[OPML 2.0 specification]: http://opml.org/spec2.opml#subscriptionLists
2023-12-31 10:00:50 -08:00
Darwin
d90667777f
request_builder.go: fetcher: Force try HTTP/2
2023-12-15 16:27:00 -08:00
Kristof Mattei
0465f9b188
fix: tests for allow popups to escape sandbox
2023-12-10 16:59:58 -08:00