southfox/miniflux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Simplify DomHelper.getVisibleElements

Browse source 
Use a `filter` instead of a loop with an index.
This commit is contained in:
jvoisin 2024-03-11 00:20:55 +01:00 committed by Frédéric Guillot
parent c51a3270da
commit fd1fee852c
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
internal/ui/static/js/dom_helper.js
View file

@ -22,16 +22,8 @@ class DomHelper {
}
static getVisibleElements(selector) {
let elements = document.querySelectorAll(selector);
let result = [];
for (let i = 0; i < elements.length; i++) {
if (this.isVisible(elements[i])) {
result.push(elements[i]);
}
}
return result;
const elements = document.querySelectorAll(selector);
return [...elements].filter((element) => this.isVisible(element));
}
static hasPassiveEventListenerOption() {