Fix some linter issues

.github/dependabot.yml

@@ -17,3 +17,12 @@ updates:
       - "fguillot"
     assignees:
       - "fguillot"
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    reviewers:
+      - "fguillot"
+    assignees:
+      - "fguillot"

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
       max-parallel: 4
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
-        go-version: [1.16, 1.17, 1.18]
+        go-version: [1.18, 1.19]
     steps:
     - name: Set up Go
       uses: actions/setup-go@v2
@@ -42,7 +42,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v2
       with:
-        go-version: 1.16
+        go-version: 1.19
     - name: Checkout
       uses: actions/checkout@v2
     - name: Install Postgres client

.github/workflows/linters.yml

@@ -25,7 +25,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.17
+          go-version: 1.19
       - uses: golangci/golangci-lint-action@v2
         with:
           args: --skip-dirs tests --disable errcheck --enable sqlclosecheck --enable misspell --enable gofmt --enable goimports --enable whitespace

cli/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package cli implements command line arguments for Miniflux application.
-
 */
 package cli // import "miniflux.app/cli"

client/doc.go

@@ -3,10 +3,9 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package client implements a client library for the Miniflux REST API.
 
-Examples
+# Examples
 
 This code snippet fetch the list of users:
 
@@ -30,6 +29,5 @@ This one discover subscriptions on a website:
 		return
 	}
 	fmt.Println(subscriptions)
-
 */
 package client // import "miniflux.app/client"

config/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package config handles configuration management for the application.
-
 */
 package config // import "miniflux.app/config"

crypto/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package crypto implements helpers related to cryptography.
-
 */
 package crypto // import "miniflux.app/crypto"

doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Miniflux is a feed reader application.
-
 */
 package main // import "miniflux.app"

errors/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package errors handles localized errors.
-
 */
 package errors // import "miniflux.app/errors"

fever/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package fever implements Fever API endpoints.
-
 */
 package fever // import "miniflux.app/fever"

fever/handler.go

@@ -76,7 +76,6 @@ an is_spark equal to 0.
 
 The “Sparks” super group is not included in this response and is composed of all feeds with an
 is_spark equal to 1.
-
 */
 func (h *handler) handleGroups(w http.ResponseWriter, r *http.Request) {
 	userID := request.UserID(r)
@@ -232,7 +231,6 @@ Three optional arguments control determine the items included in the response.
 
 	Use the with_ids argument with a comma-separated list of item ids to request (a maximum of 50) specific items.
 	(added in API version 2)
-
 */
 func (h *handler) handleItems(w http.ResponseWriter, r *http.Request) {
 	var result itemsResponse
@@ -327,6 +325,7 @@ The unread_item_ids and saved_item_ids arguments can be used to keep your local
 with the remote Fever installation.
 
 A request with the unread_item_ids argument will return one additional member:
+
 	unread_item_ids (string/comma-separated list of positive integers)
 */
 func (h *handler) handleUnreadItems(w http.ResponseWriter, r *http.Request) {
@@ -384,9 +383,9 @@ func (h *handler) handleSavedItems(w http.ResponseWriter, r *http.Request) {
 }
 
 /*
-	mark=item
+mark=item
-	as=? where ? is replaced with read, saved or unsaved
+as=? where ? is replaced with read, saved or unsaved
-	id=? where ? is replaced with the id of the item to modify
+id=? where ? is replaced with the id of the item to modify
 */
 func (h *handler) handleWriteItems(w http.ResponseWriter, r *http.Request) {
 	userID := request.UserID(r)
@@ -448,10 +447,10 @@ func (h *handler) handleWriteItems(w http.ResponseWriter, r *http.Request) {
 }
 
 /*
-	mark=feed
+mark=feed
-	as=read
+as=read
-	id=? where ? is replaced with the id of the feed or group to modify
+id=? where ? is replaced with the id of the feed or group to modify
-	before=? where ? is replaced with the Unix timestamp of the the local client’s most recent items API request
+before=? where ? is replaced with the Unix timestamp of the the local client’s most recent items API request
 */
 func (h *handler) handleWriteFeeds(w http.ResponseWriter, r *http.Request) {
 	userID := request.UserID(r)
@@ -474,10 +473,10 @@ func (h *handler) handleWriteFeeds(w http.ResponseWriter, r *http.Request) {
 }
 
 /*
-	mark=group
+mark=group
-	as=read
+as=read
-	id=? where ? is replaced with the id of the feed or group to modify
+id=? where ? is replaced with the id of the feed or group to modify
-	before=? where ? is replaced with the Unix timestamp of the the local client’s most recent items API request
+before=? where ? is replaced with the Unix timestamp of the the local client’s most recent items API request
 */
 func (h *handler) handleWriteGroups(w http.ResponseWriter, r *http.Request) {
 	userID := request.UserID(r)
@@ -512,7 +511,6 @@ A feeds_group object has the following members:
 
 	group_id (positive integer)
 	feed_ids (string/comma-separated list of positive integers)
-
 */
 func (h *handler) buildFeedGroups(feeds model.Feeds) []feedsGroups {
 	feedsGroupedByCategory := make(map[int64][]string)

fever/response.go

@@ -37,7 +37,6 @@ at least one additional member:
 
 	last_refreshed_on_time contains the time of the most recently refreshed (not updated)
 	feed (Unix timestamp/integer)
-
 */
 func newBaseResponse() baseResponse {
 	r := baseResponse{}

googlereader/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package googlereader implements Google Reader API endpoints.
-
 */
 package googlereader // import "miniflux.app/googlereader"

http/client/client.go

@@ -30,8 +30,7 @@ const (
 
 var (
 	errInvalidCertificate = "Invalid SSL certificate (original error: %q)"
-	errTemporaryNetworkOperation = "This website is temporarily unreachable (original error: %q)"
+	errNetworkOperation   = "This website is unreachable (original error: %q)"
-	errPermanentNetworkOperation = "This website is permanently unreachable (original error: %q)"
 	errRequestTimeout     = "Website unreachable, the request timed out after %d seconds"
 )
 
@@ -205,17 +204,11 @@ func (c *Client) executeRequest(request *http.Request) (*Response, error) {
 			case x509.CertificateInvalidError, x509.HostnameError:
 				err = errors.NewLocalizedError(errInvalidCertificate, uerr.Err)
 			case *net.OpError:
-				if uerr.Err.(*net.OpError).Temporary() {
+				err = errors.NewLocalizedError(errNetworkOperation, uerr.Err)
-					err = errors.NewLocalizedError(errTemporaryNetworkOperation, uerr.Err)
-				} else {
-					err = errors.NewLocalizedError(errPermanentNetworkOperation, uerr.Err)
-				}
 			case net.Error:
 				nerr := uerr.Err.(net.Error)
 				if nerr.Timeout() {
 					err = errors.NewLocalizedError(errRequestTimeout, c.ClientTimeout)
-				} else if nerr.Temporary() {
-					err = errors.NewLocalizedError(errTemporaryNetworkOperation, nerr)
 				}
 			}
 		}

http/client/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package client provides an HTTP client builder.
-
 */
 package client // import "miniflux.app/http/client"

http/cookie/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package cookie provides functions to build cookies.
-
 */
 package cookie // import "miniflux.app/http/cookie"

http/request/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package request contains helper functions to work with the HTTP request.
-
 */
 package request // import "miniflux.app/http/request"

http/response/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package response contains everything related to HTTP responses.
-
 */
 package response // import "miniflux.app/http/response"

http/response/html/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package html contains HTML response functions.
-
 */
 package html // import "miniflux.app/http/response/html"

http/response/json/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package json contains JSON response functions.
-
 */
 package json // import "miniflux.app/http/response/json"

http/response/xml/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package xml contains XML response functions.
-
 */
 package xml // import "miniflux.app/http/response/xml"

http/route/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package route contains helper functions to work with defined routes.
-
 */
 package route // import "miniflux.app/http/route"

locale/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package locale handles the internationalization of the application.
-
 */
 package locale // import "miniflux.app/locale"

locale/translations/de_DE.json

@@ -395,8 +395,7 @@
     "This feed is empty": "Dieses Abonnement ist leer",
     "This web page is empty": "Diese Webseite ist leer",
     "Invalid SSL certificate (original error: %q)": "Ungültiges SSL-Zertifikat (ursprünglicher Fehler: %q)",
-    "This website is temporarily unreachable (original error: %q)": "Diese Webseite ist vorübergehend nicht erreichbar (ursprünglicher Fehler: %q)",
+    "This website is unreachable (original error: %q)": "Diese Webseite ist nicht erreichbar (ursprünglicher Fehler: %q)",
-    "This website is permanently unreachable (original error: %q)": "Diese Webseite ist dauerhaft nicht erreichbar (ursprünglicher Fehler: %q)",
     "Website unreachable, the request timed out after %d seconds": "Webseite nicht erreichbar, die Anfrage endete nach %d Sekunden",
     "You are not authorized to access this resource (invalid username/password)": "Sie sind nicht berechtigt, auf diese Ressource zuzugreifen (Benutzername/Passwort ungültig)",
     "Unable to fetch this resource (Status Code = %d)": "Ressource konnte nicht abgerufen werden (code=%d)",

locale/translations/fr_FR.json

@@ -395,8 +395,7 @@
     "This feed is empty": "Cet abonnement est vide",
     "This web page is empty": "Cette page web est vide",
     "Invalid SSL certificate (original error: %q)": "Certificat SSL invalide (erreur originale : %q)",
-    "This website is temporarily unreachable (original error: %q)": "Ce site web est temporairement injoignable (erreur originale : %q)",
+    "This website is unreachable (original error: %q)": "Ce site web n'est pas joignable (erreur originale : %q)",
-    "This website is permanently unreachable (original error: %q)": "Ce site web n'est pas joignable de façon permanente (erreur originale : %q)",
     "Website unreachable, the request timed out after %d seconds": "Site web injoignable, la requête à échouée après %d secondes",
     "You are not authorized to access this resource (invalid username/password)": "Vous n'êtes pas autorisé à accéder à cette ressource (nom d'utilisateur / mot de passe incorrect)",
     "Unable to fetch this resource (Status Code = %d)": "Impossible de récupérer cette ressource (code=%d)",

locale/translations/nl_NL.json

@@ -396,7 +396,6 @@
     "Category not found for this user": "Categorie niet gevonden voor deze gebruiker",
     "This web page is empty": "Deze webpagina is leeg",
     "Invalid SSL certificate (original error: %q)": "Ongeldig SSL-certificaat (originele error: %q)",
-    "This website is temporarily unreachable (original error: %q)": "Deze website is tijdelijk onbereikbaar (originele error: %q)",
+    "This website is unreachable (original error: %q)": "Deze website is onbereikbaar (originele error: %q)",
-    "This website is permanently unreachable (original error: %q)": "Deze website is permanent onbereikbaar (originele error: %q)",
     "Website unreachable, the request timed out after %d seconds": "Website onbereikbaar, de request gaf een timeout na %d seconden"
 }

locale/translations/pl_PL.json

@@ -404,7 +404,6 @@
     "This feed is empty": "Ten kanał jest pusty",
     "This web page is empty": "Ta strona jest pusta",
     "Invalid SSL certificate (original error: %q)": "Certyfikat SSL jest nieprawidłowy (błąd: %q)",
-    "This website is temporarily unreachable (original error: %q)": "Ta strona jest tymczasowo niedostępna (błąd: %q)",
+    "This website is unreachable (original error: %q)": "Ta strona jest niedostępna (błąd: %q)",
-    "This website is permanently unreachable (original error: %q)": "Ta strona jest niedostępna (błąd: %q)",
     "Website unreachable, the request timed out after %d seconds": "Strona internetowa nieosiągalna, żądanie wygasło po %d sekundach"
 }

locale/translations/zh_CN.json

@@ -389,7 +389,6 @@
     "This feed is empty": "该源是空的",
     "This web page is empty": "该网页是空的",
     "Invalid SSL certificate (original error: %q)": "无效的 SSL 证书 (原始错误: %q)",
-    "This website is temporarily unreachable (original error: %q)": "该网站暂时不可达 (原始错误: %q)",
+    "This website is unreachable (original error: %q)": "该网站永久不可达 (原始错误: %q)",
-    "This website is permanently unreachable (original error: %q)": "该网站永久不可达 (原始错误: %q)",
     "Website unreachable, the request timed out after %d seconds": "网站不可达, 请求已在 %d 秒后超时"
 }

locale/translations/zh_TW.json

@@ -397,7 +397,6 @@
     "This feed is empty": "該Feed是空的",
     "This web page is empty": "該網頁是空的",
     "Invalid SSL certificate (original error: %q)": "無效的 SSL 憑證 (錯誤: %q)",
-    "This website is temporarily unreachable (original error: %q)": "該網站暫時無法訪問 (原始錯誤: %q)",
+    "This website is unreachable (original error: %q)": "該網站永久無法訪問(原始錯誤: %q)",
-    "This website is permanently unreachable (original error: %q)": "該網站永久無法訪問(原始錯誤: %q)",
     "Website unreachable, the request timed out after %d seconds": "網站無法訪問, 請求已在 %d 秒後超時"
 }

logger/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package logger handles application log messages with different levels.
-
 */
 package logger // import "miniflux.app/logger"

model/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package model contains all data structures used by the application.
-
 */
 package model // import "miniflux.app/model"

oauth2/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package oauth2 abstracts different OAuth2 providers.
-
 */
 package oauth2 // import "miniflux.app/oauth2"

reader/atom/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package atom provides an Atom feed parser.
-
 */
 package atom // import "miniflux.app/reader/atom"

reader/browser/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package browser handles website crawling.
-
 */
 package browser // import "miniflux.app/reader/browser"

reader/date/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package date provides a feed date parser.
-
 */
 package date // import "miniflux.app/reader/date"

reader/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package reader implements everything related to feed parsing.
-
 */
 package reader // import "miniflux.app/reader"

reader/encoding/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package encoding handles workarounds to deal with encoding edge cases found into feeds.
-
 */
 package encoding // import "miniflux.app/reader/encoding"

reader/icon/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package icon provides all the logic to download website icons.
-
 */
 package icon // import "miniflux.app/reader/icon"

reader/json/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package json provides a JSON feed parser.
-
 */
 package json // import "miniflux.app/reader/json"

reader/opml/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package opml provides an OPML parser and writer.
-
 */
 package opml // import "miniflux.app/reader/opml"

reader/parser/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package parser provides a generic feed parser that abstract all different formats.
-
 */
 package parser // import "miniflux.app/reader/parser"

reader/processor/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package processor applies rules and sanitize content for feed entries.
-
 */
 package processor // import "miniflux.app/reader/processor"

reader/rdf/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package rdf provides a RDF feed parser.
-
 */
 package rdf // import "miniflux.app/reader/rdf"

reader/readability/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package readability implements a web page scraper that returns only relevant content.
-
 */
 package readability // import "miniflux.app/reader/readability"

reader/rewrite/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package rewrite provides functions to manipulate feed contents.
-
 */
 package rewrite // import "miniflux.app/reader/rewrite"

reader/rss/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package rss provides a RSS feed parser.
-
 */
 package rss // import "miniflux.app/reader/rss"

reader/sanitizer/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package sanitizer implements a HTML sanitizer that removes unsafe elements.
-
 */
 package sanitizer // import "miniflux.app/reader/sanitizer"

reader/scraper/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package scraper implements a web page crawler.
-
 */
 package scraper // import "miniflux.app/reader/scraper"

reader/subscription/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package subscription implements the logic to find subscriptions on a website.
-
 */
 package subscription // import "miniflux.app/reader/subscription"

service/httpd/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package httpd implements the HTTP service.
-
 */
 package httpd // import "miniflux.app/service/httpd"

service/scheduler/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package scheduler implements the scheduler service.
-
 */
 package scheduler // import "miniflux.app/service/scheduler"

storage/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package storage implements a set of functions to interact with the database.
-
 */
 package storage // import "miniflux.app/storage"

tests/category_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

tests/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package tests contains API integration tests.
-
 */
 package tests // import "miniflux.app/tests"

tests/endpoint_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

tests/feed_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

tests/import_export_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

tests/subscription_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

tests/tests.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by the Apache 2.0
 // license that can be found in the LICENSE file.
 
+//go:build integration
 // +build integration
 
 package tests

timer/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package timer implements utility functions to measure the execution time of a block of code.
-
 */
 package timer // import "miniflux.app/timer"

timezone/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package timezone contains helper functions to work with timezones.
-
 */
 package timezone // import "miniflux.app/timezone"

ui/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package ui implements handlers to render to user interface.
-
 */
 package ui // import "miniflux.app/ui"

ui/form/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package form handles HTML form validation and serialization.
-
 */
 package form // import "miniflux.app/ui/form"

ui/session/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package session provides helper functions to work with the user session.
-
 */
 package session // import "miniflux.app/ui/session"

ui/static/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package static contains assets for the user interface.
-
 */
 package static // import "miniflux.app/ui/static"

ui/view/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package view handles template parameters.
-
 */
 package view // import "miniflux.app/ui/view"

url/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package url implements a set of utility functions to parse URL.
-
 */
 package url // import "miniflux.app/url"

version/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package version contains application and build information.
-
 */
 package version // import "miniflux.app/version"

worker/doc.go

@@ -3,8 +3,6 @@
 // license that can be found in the LICENSE file.
 
 /*
-
 Package worker implements the background workers.
-
 */
 package worker // import "miniflux.app/worker"