southfox/miniflux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fetcher: use ETag as a stronger validator than Last-Modified

Browse source 
As per the MDN article on HTTP caching:

  During cache revalidation, if both If-Modified-Since and If-None-Match
  are present, then If-None-Match takes precedence for the validator.

  https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching

Previously Miniflux would consider a resource unmodified if the
Last-Modified header had not changed, even if the ETag had changed.

With this commit, Miniflux will consider a resource modified if the ETag
header has changed, even if Last-Modified has not.

This fixes Bug 1 in https://rachelbythebay.com/w/2024/06/11/fsr/
This commit is contained in:
Scott Leggett 2024-07-02 23:12:53 +08:00 committed by Frédéric Guillot
parent c787bb5b48
commit bf1c851093
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
internal/reader/fetcher/response_handler.go
View file

@ -56,12 +56,12 @@ func (r *ResponseHandler) IsModified(lastEtagValue, lastModifiedValue string) bo
return false
}
if r.ETag() != "" && r.ETag() == lastEtagValue {
return false
if r.ETag() != "" {
return r.ETag() != lastEtagValue
}
if r.LastModified() != "" && r.LastModified() == lastModifiedValue {
return false
if r.LastModified() != "" {
return r.LastModified() != lastModifiedValue
}
return true