2017-11-20 06:10:04 +01:00
package html // import "github.com/tdewolff/minify/html"
import (
"bytes"
"fmt"
"io"
"io/ioutil"
"net/url"
"os"
"regexp"
"testing"
"github.com/tdewolff/minify"
"github.com/tdewolff/minify/css"
"github.com/tdewolff/minify/js"
"github.com/tdewolff/minify/json"
"github.com/tdewolff/minify/svg"
"github.com/tdewolff/minify/xml"
"github.com/tdewolff/test"
)
func TestHTML ( t * testing . T ) {
htmlTests := [ ] struct {
html string
expected string
} {
{ ` html ` , ` html ` } ,
{ ` <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.0//EN" "http://www.w3.org/MarkUp/DTD/xhtml-rdfa-1.dtd"> ` , ` <!doctype html> ` } ,
{ ` <!-- comment --> ` , ` ` } ,
{ ` <style><!--\ncss\n--></style> ` , ` <style><!--\ncss\n--></style> ` } ,
{ ` <style>&</style> ` , ` <style>&</style> ` } ,
{ ` <html><head></head><body>x</body></html> ` , ` x ` } ,
{ ` <meta http-equiv="content-type" content="text/html; charset=utf-8"> ` , ` <meta charset=utf-8> ` } ,
{ ` <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> ` , ` <meta charset=utf-8> ` } ,
{ ` <meta name="keywords" content="a, b"> ` , ` <meta name=keywords content=a,b> ` } ,
{ ` <meta name="viewport" content="width = 996" /> ` , ` <meta name=viewport content="width=996"> ` } ,
{ ` <span attr="test"></span> ` , ` <span attr=test></span> ` } ,
{ ` <span attr='test'test'></span> ` , ` <span attr="test'test"></span> ` } ,
{ ` <span attr="test"test"></span> ` , ` <span attr='test"test'></span> ` } ,
{ ` <span attr='test""'&test'></span> ` , ` <span attr='test""'&test'></span> ` } ,
{ ` <span attr="test/test"></span> ` , ` <span attr=test/test></span> ` } ,
{ ` <span>&</span> ` , ` <span>&</span> ` } ,
{ ` <span clear=none method=GET></span> ` , ` <span></span> ` } ,
{ ` <span onload="javascript:x;"></span> ` , ` <span onload=x;></span> ` } ,
{ ` <span selected="selected"></span> ` , ` <span selected></span> ` } ,
{ ` <noscript><html><img id="x"></noscript> ` , ` <noscript><img id=x></noscript> ` } ,
{ ` <body id="main"></body> ` , ` <body id=main> ` } ,
{ ` <link href="data:text/plain, data"> ` , ` <link href=data:,+data> ` } ,
{ ` <svg width="100" height="100"><circle cx="50" cy="50" r="40" stroke="green" stroke-width="4" fill="yellow" /></svg> ` , ` <svg width="100" height="100"><circle cx="50" cy="50" r="40" stroke="green" stroke-width="4" fill="yellow" /></svg> ` } ,
{ ` </span > ` , ` </span> ` } ,
{ ` <meta name=viewport content="width=0.1, initial-scale=1.0 , maximum-scale=1000"> ` , ` <meta name=viewport content="width=.1,initial-scale=1,maximum-scale=1e3"> ` } ,
{ ` <br/> ` , ` <br> ` } ,
// increase coverage
{ ` <script style="css">js</script> ` , ` <script style=css>js</script> ` } ,
{ ` <script type="application/javascript">js</script> ` , ` <script type=application/javascript>js</script> ` } ,
{ ` <meta http-equiv="content-type" content="text/plain, text/html"> ` , ` <meta http-equiv=content-type content=text/plain,text/html> ` } ,
{ ` <meta http-equiv="content-style-type" content="text/less"> ` , ` <meta http-equiv=content-style-type content=text/less> ` } ,
{ ` <meta http-equiv="content-style-type" content="text/less; charset=utf-8"> ` , ` <meta http-equiv=content-style-type content="text/less;charset=utf-8"> ` } ,
{ ` <meta http-equiv="content-script-type" content="application/js"> ` , ` <meta http-equiv=content-script-type content=application/js> ` } ,
{ ` <span attr=""></span> ` , ` <span attr></span> ` } ,
{ ` <code>x</code> ` , ` <code>x</code> ` } ,
{ ` <p></p><p></p> ` , ` <p><p> ` } ,
{ ` <ul><li></li> <li></li></ul> ` , ` <ul><li><li></ul> ` } ,
{ ` <p></p><a></a> ` , ` <p></p><a></a> ` } ,
{ ` <p></p>x<a></a> ` , ` <p></p>x<a></a> ` } ,
{ ` <span style=> ` , ` <span> ` } ,
{ ` <button onclick=> ` , ` <button> ` } ,
// whitespace
{ ` cats and dogs ` , ` cats and dogs ` } ,
{ ` <div> <i> test </i> <b> test </b> </div> ` , ` <div><i>test</i> <b>test</b></div> ` } ,
{ ` <strong>x </strong>y ` , ` <strong>x </strong>y ` } ,
{ ` <strong>x </strong> y ` , ` <strong>x</strong> y ` } ,
{ "<strong>x </strong>\ny" , "<strong>x</strong>\ny" } ,
{ ` <p>x </p>y ` , ` <p>x</p>y ` } ,
{ ` x <p>y</p> ` , ` x<p>y ` } ,
{ ` <!doctype html> <!--comment--> <html> <body><p></p></body></html> ` , ` <!doctype html><p> ` } , // spaces before html and at the start of html are dropped
{ ` <p>x<br> y ` , ` <p>x<br>y ` } ,
{ ` <p>x </b> <b> y ` , ` <p>x</b> <b>y ` } ,
{ ` a <code></code> b ` , ` a <code></code>b ` } ,
{ ` a <code>code</code> b ` , ` a <code>code</code> b ` } ,
{ ` a <code> code </code> b ` , ` a <code>code</code> b ` } ,
{ ` a <script>script</script> b ` , ` a <script>script</script>b ` } ,
{ "text\n<!--comment-->\ntext" , "text\ntext" } ,
{ "abc\n</body>\ndef" , "abc\ndef" } ,
{ "<x>\n<!--y-->\n</x>" , "<x></x>" } ,
{ "a <template> b </template> c" , "a <template>b</template>c" } ,
// from HTML Minifier
{ ` <DIV TITLE="blah">boo</DIV> ` , ` <div title=blah>boo</div> ` } ,
{ "<p title\n\n\t =\n \"bar\">foo</p>" , ` <p title=bar>foo ` } ,
{ ` <p class=" foo ">foo bar baz</p> ` , ` <p class=foo>foo bar baz ` } ,
{ ` <input maxlength=" 5 "> ` , ` <input maxlength=5> ` } ,
{ ` <input type="text"> ` , ` <input> ` } ,
{ ` <form method="get"> ` , ` <form> ` } ,
{ ` <script language="Javascript">alert(1)</script> ` , ` <script>alert(1)</script> ` } ,
{ ` <script></script> ` , ` ` } ,
{ ` <p onclick=" JavaScript: x">x</p> ` , ` <p onclick=" x">x ` } ,
{ ` <span Selected="selected"></span> ` , ` <span selected></span> ` } ,
{ ` <table><thead><tr><th>foo</th><th>bar</th></tr></thead><tfoot><tr><th>baz</th><th>qux</th></tr></tfoot><tbody><tr><td>boo</td><td>moo</td></tr></tbody></table> ` ,
` <table><thead><tr><th>foo<th>bar<tfoot><tr><th>baz<th>qux<tbody><tr><td>boo<td>moo</table> ` } ,
{ ` <select><option>foo</option><option>bar</option></select> ` , ` <select><option>foo<option>bar</select> ` } ,
{ ` <meta name="keywords" content="A, B"> ` , ` <meta name=keywords content=A,B> ` } ,
{ ` <iframe><html> <p> x </p> </html></iframe> ` , ` <iframe><p>x</iframe> ` } ,
{ ` <math> ∫_a_^b^ { f(x)<over>1+x} dx </math> ` , ` <math> ∫_a_^b^ { f(x)<over>1+x} dx </math> ` } ,
{ ` <script language="x" charset="x" src="y"></script> ` , ` <script src=y></script> ` } ,
{ ` <style media="all">x</style> ` , ` <style>x</style> ` } ,
{ ` <a id="abc" name="abc">y</a> ` , ` <a id=abc>y</a> ` } ,
{ ` <a id="" value="">y</a> ` , ` <a value>y</a> ` } ,
// from Kangax html-minfier
{ ` <span style="font-family:"Helvetica Neue","Helvetica",Helvetica,Arial,sans-serif">text</span> ` , ` <span style='font-family:"Helvetica Neue","Helvetica",Helvetica,Arial,sans-serif'>text</span> ` } ,
// go-fuzz
{ ` <meta e t n content=ful><a b ` , ` <meta e t n content=ful><a b> ` } ,
{ ` <img alt=a'b=""> ` , ` <img alt='a'b=""'> ` } ,
{ ` </b ` , ` </b ` } ,
2017-12-16 20:25:18 +01:00
{ ` <title></ ` , ` <title></ ` } ,
{ ` <svg < ` , ` <svg < ` } ,
{ ` <svg " ` , ` <svg " ` } ,
{ ` <svg></ ` , ` <svg></ ` } ,
{ ` <script><!--< ` , ` <script><!--< ` } ,
2017-11-20 06:10:04 +01:00
// bugs
{ ` <p>text</p><br>text ` , ` <p>text</p><br>text ` } , // #122
{ ` text <img> text ` , ` text <img> text ` } , // #89
{ ` text <progress></progress> text ` , ` text <progress></progress> text ` } , // #89
{ ` <pre> <x> a b </x> </pre> ` , ` <pre> <x> a b </x> </pre> ` } , // #82
{ ` <svg id="1"></svg> ` , ` <svg id="1"></svg> ` } , // #67
}
m := minify . New ( )
m . AddFunc ( "text/html" , Minify )
m . AddFunc ( "text/css" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
_ , err := io . Copy ( w , r )
return err
} )
m . AddFunc ( "text/javascript" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
_ , err := io . Copy ( w , r )
return err
} )
for _ , tt := range htmlTests {
t . Run ( tt . html , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
err := Minify ( m , w , r , nil )
test . Minify ( t , tt . html , err , w . String ( ) , tt . expected )
} )
}
}
func TestHTMLKeepEndTags ( t * testing . T ) {
htmlTests := [ ] struct {
html string
expected string
} {
{ ` <p></p><p></p> ` , ` <p></p><p></p> ` } ,
{ ` <ul><li></li><li></li></ul> ` , ` <ul><li></li><li></li></ul> ` } ,
}
m := minify . New ( )
htmlMinifier := & Minifier { KeepEndTags : true }
for _ , tt := range htmlTests {
t . Run ( tt . html , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
err := htmlMinifier . Minify ( m , w , r , nil )
test . Minify ( t , tt . html , err , w . String ( ) , tt . expected )
} )
}
}
func TestHTMLKeepConditionalComments ( t * testing . T ) {
htmlTests := [ ] struct {
html string
expected string
} {
{ ` <!--[if IE 6]> <b> </b> <![endif]--> ` , ` <!--[if IE 6]><b></b><![endif]--> ` } ,
{ ` <![if IE 6]> <b> </b> <![endif]> ` , ` <![if IE 6]><b></b><![endif]> ` } ,
}
m := minify . New ( )
htmlMinifier := & Minifier { KeepConditionalComments : true }
for _ , tt := range htmlTests {
t . Run ( tt . html , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
err := htmlMinifier . Minify ( m , w , r , nil )
test . Minify ( t , tt . html , err , w . String ( ) , tt . expected )
} )
}
}
func TestHTMLKeepWhitespace ( t * testing . T ) {
htmlTests := [ ] struct {
html string
expected string
} {
{ ` cats and dogs ` , ` cats and dogs ` } ,
{ ` <div> <i> test </i> <b> test </b> </div> ` , ` <div> <i> test </i> <b> test </b> </div> ` } ,
{ ` <strong>x </strong>y ` , ` <strong>x </strong>y ` } ,
{ ` <strong>x </strong> y ` , ` <strong>x </strong> y ` } ,
{ "<strong>x </strong>\ny" , "<strong>x </strong>\ny" } ,
{ ` <p>x </p>y ` , ` <p>x </p>y ` } ,
{ ` x <p>y</p> ` , ` x <p>y ` } ,
{ ` <!doctype html> <!--comment--> <html> <body><p></p></body></html> ` , ` <!doctype html><p> ` } , // spaces before html and at the start of html are dropped
{ ` <p>x<br> y ` , ` <p>x<br> y ` } ,
{ ` <p>x </b> <b> y ` , ` <p>x </b> <b> y ` } ,
{ ` a <code>code</code> b ` , ` a <code>code</code> b ` } ,
{ ` a <code></code> b ` , ` a <code></code> b ` } ,
{ ` a <script>script</script> b ` , ` a <script>script</script> b ` } ,
{ "text\n<!--comment-->\ntext" , "text\ntext" } ,
{ "text\n<!--comment-->text<!--comment--> text" , "text\ntext text" } ,
{ "abc\n</body>\ndef" , "abc\ndef" } ,
{ "<x>\n<!--y-->\n</x>" , "<x>\n</x>" } ,
{ "<style>lala{color:red}</style>" , "<style>lala{color:red}</style>" } ,
}
m := minify . New ( )
htmlMinifier := & Minifier { KeepWhitespace : true }
for _ , tt := range htmlTests {
t . Run ( tt . html , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
err := htmlMinifier . Minify ( m , w , r , nil )
test . Minify ( t , tt . html , err , w . String ( ) , tt . expected )
} )
}
}
func TestHTMLURL ( t * testing . T ) {
htmlTests := [ ] struct {
url string
html string
expected string
} {
{ ` http://example.com/ ` , ` <a href=http://example.com/>link</a> ` , ` <a href=//example.com/>link</a> ` } ,
{ ` https://example.com/ ` , ` <a href=http://example.com/>link</a> ` , ` <a href=http://example.com/>link</a> ` } ,
{ ` http://example.com/ ` , ` <a href=https://example.com/>link</a> ` , ` <a href=https://example.com/>link</a> ` } ,
{ ` https://example.com/ ` , ` <a href=https://example.com/>link</a> ` , ` <a href=//example.com/>link</a> ` } ,
{ ` http://example.com/ ` , ` <a href=" http://example.com ">x</a> ` , ` <a href=//example.com>x</a> ` } ,
{ ` http://example.com/ ` , ` <link rel="stylesheet" type="text/css" href="http://example.com"> ` , ` <link rel=stylesheet href=//example.com> ` } ,
{ ` http://example.com/ ` , ` <!doctype html> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"> <head profile="http://dublincore.org/documents/dcq-html/"> <!-- Barlesque 2.75.0 --> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> ` ,
` <!doctype html><html xmlns=//www.w3.org/1999/xhtml xml:lang=en><head profile=//dublincore.org/documents/dcq-html/><meta charset=utf-8> ` } ,
{ ` http://example.com/ ` , ` <html xmlns="http://www.w3.org/1999/xhtml"></html> ` , ` <html xmlns=//www.w3.org/1999/xhtml> ` } ,
{ ` https://example.com/ ` , ` <html xmlns="http://www.w3.org/1999/xhtml"></html> ` , ` <html xmlns=http://www.w3.org/1999/xhtml> ` } ,
{ ` http://example.com/ ` , ` <html xmlns="https://www.w3.org/1999/xhtml"></html> ` , ` <html xmlns=https://www.w3.org/1999/xhtml> ` } ,
{ ` https://example.com/ ` , ` <html xmlns="https://www.w3.org/1999/xhtml"></html> ` , ` <html xmlns=//www.w3.org/1999/xhtml> ` } ,
}
m := minify . New ( )
m . AddFunc ( "text/html" , Minify )
for _ , tt := range htmlTests {
t . Run ( tt . url , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
m . URL , _ = url . Parse ( tt . url )
err := Minify ( m , w , r , nil )
test . Minify ( t , tt . html , err , w . String ( ) , tt . expected )
} )
}
}
func TestSpecialTagClosing ( t * testing . T ) {
m := minify . New ( )
m . AddFunc ( "text/html" , Minify )
m . AddFunc ( "text/css" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
b , err := ioutil . ReadAll ( r )
test . Error ( t , err , nil )
test . String ( t , string ( b ) , "</script>" )
_ , err = w . Write ( b )
return err
} )
html := ` <style></script></style> `
r := bytes . NewBufferString ( html )
w := & bytes . Buffer { }
err := Minify ( m , w , r , nil )
test . Minify ( t , html , err , w . String ( ) , html )
}
func TestReaderErrors ( t * testing . T ) {
r := test . NewErrorReader ( 0 )
w := & bytes . Buffer { }
m := minify . New ( )
err := Minify ( m , w , r , nil )
test . T ( t , err , test . ErrPlain , "return error at first read" )
}
func TestWriterErrors ( t * testing . T ) {
errorTests := [ ] struct {
html string
n [ ] int
} {
{ ` <!doctype> ` , [ ] int { 0 } } ,
{ ` text ` , [ ] int { 0 } } ,
{ ` <foo attr=val> ` , [ ] int { 0 , 1 , 2 , 3 , 4 , 5 } } ,
{ ` </foo> ` , [ ] int { 0 } } ,
{ ` <style>x</style> ` , [ ] int { 2 } } ,
{ ` <textarea>x</textarea> ` , [ ] int { 2 } } ,
{ ` <code>x</code> ` , [ ] int { 2 } } ,
{ ` <pre>x</pre> ` , [ ] int { 2 } } ,
{ ` <svg>x</svg> ` , [ ] int { 0 } } ,
{ ` <math>x</math> ` , [ ] int { 0 } } ,
{ ` <!--[if IE 6]> text <![endif]--> ` , [ ] int { 0 , 1 , 2 } } ,
{ ` <![if IE 6]> text <![endif]> ` , [ ] int { 0 } } ,
}
m := minify . New ( )
m . Add ( "text/html" , & Minifier {
KeepConditionalComments : true ,
} )
for _ , tt := range errorTests {
for _ , n := range tt . n {
t . Run ( fmt . Sprint ( tt . html , " " , tt . n ) , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := test . NewErrorWriter ( n )
err := m . Minify ( "text/html" , w , r )
test . T ( t , err , test . ErrPlain )
} )
}
}
}
func TestMinifyErrors ( t * testing . T ) {
errorTests := [ ] struct {
html string
err error
} {
{ ` <style>abc</style> ` , test . ErrPlain } ,
{ ` <path style="abc"/> ` , test . ErrPlain } ,
{ ` <path onclick="abc"/> ` , test . ErrPlain } ,
{ ` <svg></svg> ` , test . ErrPlain } ,
{ ` <math></math> ` , test . ErrPlain } ,
}
m := minify . New ( )
m . AddFunc ( "text/css" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
return test . ErrPlain
} )
m . AddFunc ( "text/javascript" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
return test . ErrPlain
} )
m . AddFunc ( "image/svg+xml" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
return test . ErrPlain
} )
m . AddFunc ( "application/mathml+xml" , func ( _ * minify . M , w io . Writer , r io . Reader , _ map [ string ] string ) error {
return test . ErrPlain
} )
for _ , tt := range errorTests {
t . Run ( tt . html , func ( t * testing . T ) {
r := bytes . NewBufferString ( tt . html )
w := & bytes . Buffer { }
err := Minify ( m , w , r , nil )
test . T ( t , err , tt . err )
} )
}
}
////////////////////////////////////////////////////////////////
func ExampleMinify ( ) {
m := minify . New ( )
m . AddFunc ( "text/html" , Minify )
m . AddFunc ( "text/css" , css . Minify )
m . AddFunc ( "text/javascript" , js . Minify )
m . AddFunc ( "image/svg+xml" , svg . Minify )
m . AddFuncRegexp ( regexp . MustCompile ( "[/+]json$" ) , json . Minify )
m . AddFuncRegexp ( regexp . MustCompile ( "[/+]xml$" ) , xml . Minify )
// set URL to minify link locations too
m . URL , _ = url . Parse ( "https://www.example.com/" )
if err := m . Minify ( "text/html" , os . Stdout , os . Stdin ) ; err != nil {
panic ( err )
}
}
func ExampleMinify_options ( ) {
m := minify . New ( )
m . Add ( "text/html" , & Minifier {
KeepDefaultAttrVals : true ,
KeepWhitespace : true ,
} )
if err := m . Minify ( "text/html" , os . Stdout , os . Stdin ) ; err != nil {
panic ( err )
}
}
func ExampleMinify_reader ( ) {
b := bytes . NewReader ( [ ] byte ( "<html><body><h1>Example</h1></body></html>" ) )
m := minify . New ( )
m . Add ( "text/html" , & Minifier { } )
r := m . Reader ( "text/html" , b )
if _ , err := io . Copy ( os . Stdout , r ) ; err != nil {
panic ( err )
}
// Output: <h1>Example</h1>
}
func ExampleMinify_writer ( ) {
m := minify . New ( )
m . Add ( "text/html" , & Minifier { } )
w := m . Writer ( "text/html" , os . Stdout )
w . Write ( [ ] byte ( "<html><body><h1>Example</h1></body></html>" ) )
w . Close ( )
// Output: <h1>Example</h1>
}
