From 97e5d9880258e2832310a05a35e6dca117da6a42 Mon Sep 17 00:00:00 2001
From: southfox <master@southfox.me>
Date: Fri, 7 Apr 2023 14:07:59 +0800
Subject: [PATCH] [tests] add some comments in test inbox

---
 tests/test_inbox.py | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/tests/test_inbox.py b/tests/test_inbox.py
index c4da4a7..ffe18f6 100644
--- a/tests/test_inbox.py
+++ b/tests/test_inbox.py
@@ -29,6 +29,7 @@ def test_inbox_follow_request(
     ) -> bool:
         return True
 
+    # build test actor
     ra = factories.RemoteActorFactory(
         base_url="https://example.com",
         username="test",
@@ -36,11 +37,13 @@ def test_inbox_follow_request(
     )
 
     ap_id = ra.ap_id # type: ignore
+    app.dependency_overrides[precheck.inbox_prechecker] = inbox_prechecker
+
+    # mock request
     respx_mock.get(ap_id).mock(return_value=httpx.Response(200,json=ra.ap_actor))
     respx_mock.post(ap_id + "/inbox").mock(return_value=httpx.Response(202))
 
-    app.dependency_overrides[precheck.inbox_prechecker] = inbox_prechecker
-
+    # send follower request
     with mock.patch("app.boxes.MANUALLY_APPROVES_FOLLOWERS", False):
         response = client.post(
             "/inbox",
@@ -53,14 +56,16 @@ def test_inbox_follow_request(
                 "object": ap.ME["id"],
             },
         )
-
     assert response.status_code == 202
 
+    # actor was saved in actor table
     saved_actor = db.execute(select(models.Actor)).scalar_one()
     assert saved_actor.ap_id == ap_id
 
-    follower_actor = db.execute(select(models.Follower)).scalar_one()
-    assert follower_actor.ap_actor_id == ap_id
-
+    # follower request was saved in outbox table
     outbox_object = db.execute(select(models.OutboxObject)).scalar_one()
     assert outbox_object.ap_type == "Accept"
+
+    # follower was saved in follower table
+    follower_actor = db.execute(select(models.Follower)).scalar_one()
+    assert follower_actor.ap_actor_id == ap_id