import: github: Improve readability.

* guix/import/github.scm (latest-released-version)[release->version]: Separate
out release->version as a new function.
This commit is contained in:
Arun Isaac 2019-05-14 15:44:46 +05:30
parent 0f9bbd32c1
commit c558772b0f
No known key found for this signature in database
GPG key ID: 2E25EE8B61802BB3

View file

@ -174,17 +174,7 @@ (define (latest-released-version url package-name)
(define (pre-release? x)
(hash-ref x "prerelease"))
(let* ((json (fetch-releases-or-tags url)))
(if (eq? json #f)
(if (%github-token)
(error "Error downloading release information through the GitHub
API when using a GitHub token")
(error "Error downloading release information through the GitHub
API. This may be fixed by using an access token and setting the environment
variable GUIX_GITHUB_TOKEN, for instance one procured from
https://github.com/settings/tokens"))
(any
(lambda (release)
(define (release->version release)
(let ((tag (or (hash-ref release "tag_name") ;a "release"
(hash-ref release "name"))) ;a tag
(name-length (string-length package-name)))
@ -206,6 +196,17 @@ (define (pre-release? x)
(string-ref tag 0)))
tag)
(else #f))))
(let* ((json (fetch-releases-or-tags url)))
(if (eq? json #f)
(if (%github-token)
(error "Error downloading release information through the GitHub
API when using a GitHub token")
(error "Error downloading release information through the GitHub
API. This may be fixed by using an access token and setting the environment
variable GUIX_GITHUB_TOKEN, for instance one procured from
https://github.com/settings/tokens"))
(any release->version
(match (remove pre-release? json)
(() json) ; keep everything
(releases releases))))))